[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Cleanup code by using common FAST_SPI module

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19055 )

Change subject: soc/intel/skylake: Cleanup code by using common FAST_SPI module
......................................................................

Patch Set 1:

(10 comments)

https://review.coreboot.org/#/c/19055/1/src/soc/intel/skylake/bootblock/cpu....
File src/soc/intel/skylake/bootblock/cpu.c:

PS1, Line 30: #include <intelblocks/fast_spi.h>
alphabetic order?

https://review.coreboot.org/#/c/19055/1/src/soc/intel/skylake/bootblock/pch....
File src/soc/intel/skylake/bootblock/pch.c:

PS1, Line 57: PCH_DEV_SPI
use device_t local there.

https://review.coreboot.org/#/c/19055/1/src/soc/intel/skylake/finalize.c
File src/soc/intel/skylake/finalize.c:

PS1, Line 33: #include <intelblocks/fast_spi.h>
order?

PS1, Line 92: 	fast_spi_set_opcode_menu();
            : 	fast_spi_lock_bar();
why removed comments as well?

PS1, Line 160: 		fast_spi_set_bios_interface_lock_down();
put comments

https://review.coreboot.org/#/c/19055/1/src/soc/intel/skylake/flash_controll...
File src/soc/intel/skylake/flash_controller.c:

PS1, Line 27: #include <intelblocks/fast_spi_def.h>
alphabetic order

https://review.coreboot.org/#/c/19055/1/src/soc/intel/skylake/include/soc/pc...
File src/soc/intel/skylake/include/soc/pch.h:

PS1, Line 38: //u32 pch_read_soft_strap(int id);
why commented code?

https://review.coreboot.org/#/c/19055/1/src/soc/intel/skylake/pch.c
File src/soc/intel/skylake/pch.c:

PS1, Line 27: #include <intelblocks/fast_spi.h>
alphabetic order

PS1, Line 39: /*u32 pch_read_soft_strap(int id)
            : {
            : 	uint32_t fdoc;
            : 	void *spibar = get_fast_spi_bar();
            : 
            : 	fdoc = read32(spibar + SPIBAR_FDOC);
            : 	fdoc &= ~0x00007ffc;
            : 	write32(spibar + SPIBAR_FDOC, fdoc);
            : 
            : 	fdoc |= 0x00004000;
            : 	fdoc |= id * 4;
            : 	write32(spibar + SPIBAR_FDOC, fdoc);
            : 
            : 	return read32(spibar + SPIBAR_FDOD);
            : }*/
commented code? why?

https://review.coreboot.org/#/c/19055/1/src/soc/intel/skylake/romstage/romst...
File src/soc/intel/skylake/romstage/romstage.c:

PS1, Line 41: #include <intelblocks/fast_spi.h>
alphabetic order