[coreboot-gerrit] Change in coreboot[master]: mb/asus/p5ql-em: Add mainboard

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31323 )

Change subject: mb/asus/p5ql-em: Add mainboard
......................................................................

Patch Set 15:

(3 comments)

https://review.coreboot.org/c/coreboot/+/31323/14/src/mainboard/asus/p5ql-em... 
File src/mainboard/asus/p5ql-em/romstage.c:

https://review.coreboot.org/c/coreboot/+/31323/14/src/mainboard/asus/p5ql-em... 
PS14, Line 85: 	pnp_write_config(GPIO_DEV, 0xf0, 0xf3); /* GPIO3 direction */
GPIO3x ?

https://review.coreboot.org/c/coreboot/+/31323/14/src/mainboard/asus/p5ql-em... 
PS14, Line 87: 	pnp_write_config(GPIO_DEV, 0xf4, 0x06); /* GPIO4 direction */
GPIO4x ?

https://review.coreboot.org/c/coreboot/+/31323/14/src/mainboard/asus/p5ql-em... 
PS14, Line 93: 	pnp_write_config(GPIO_DEV, 0xf1, old_reg | reg | 4);
> I guess this is solved

Comments need improvement. Without opening the datasheet, I imagined GPIO32 as input.