Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40545 )
Change subject: arch/x86/smbios: Add SMBIOS type8 data
......................................................................
Patch Set 6:
(2 comments)
Patch Set 4:
(2 comments)
I've updated it.
https://review.coreboot.org/c/coreboot/+/40545/4/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/40545/4/src/arch/x86/smbios.c@894
PS4, Line 894: const struct port_information *__weak smbios_get_port_info(size_t *num_ports)
that's usually used to option a single string or object
Ack
https://review.coreboot.org/c/coreboot/+/40545/4/src/arch/x86/smbios.c@900
PS4, Line 900: static int smbios_write_type8(unsigned long *current, int *handle)
I'd prefer a "type9" or "type38" solution. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81e25d27c9c6717750edf1d547e5f4cfb8f1da14
Gerrit-Change-Number: 40545
Gerrit-PatchSet: 6
Gerrit-Owner: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 11 May 2020 03:25:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment