Attention is currently required from: Karthik Ramasubramanian, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86228?usp=email )
Change subject: vc/google/chromeos: Implement platform callback for critical shutdown
......................................................................
Patch Set 9:
(1 comment)
File src/vendorcode/google/chromeos/battery.c:
https://review.coreboot.org/c/coreboot/+/86228/comment/eff080ef_769eef83?usp... :
PS9, Line 49: void platform_issue_low_battery_shutdown(void)
Due to CB:86336 we can move this into common code somewhere, it doesn't need to be in `vendorcode/chromeos` and be called `platform_...` anymore.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86228?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I119f80a45c045a6095cae98f179c755a2e948e9c
Gerrit-Change-Number: 86228
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 11 Feb 2025 00:18:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No