[coreboot-gerrit] Change in coreboot[master]: Revert "Makefile.inc: Drop the cbfs master header from non-X86"

[Julius Werner (Code Review)]

Attention is currently required from: Hung-Te Lin, Martin Roth, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56130 )

Change subject: Revert "Makefile.inc: Drop the cbfs master header from non-X86"
......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/56130/comment/61b9dcaa_36125cf8 
PS1, Line 11: Breaks libpayload CBFS code when accessing
            : non-primary CBFS.
> I see that there is FMAP support in libpayload.

No, there isn... wait, you mean libc/fmap.c? Hmmm... never seen that before to be honest, depthcharge isn't using it. Not sure if anyone else is. Maybe Patrick knows more about that, it looks like he wrote it. Maybe it's some sort of aborted attempt?

I agree that putting FMAP integration into the libpayload CBFS code would probably be the right long-term move, but I'm not sure if that existing FMAP code actually works. I think it has never been used. Would be good to have something there that could ideally also fetch and use coreboot's FMAP cache from CBMEM if it exists.