Attention is currently required from: Angel Pons, Arthur Heymans, Iru Cai, Maxim, Name of user not set #1001638, Paul Menzel.
Nicholas Chin has posted comments on this change by Iru Cai. ( https://review.coreboot.org/c/coreboot/+/30890?usp=email )
Change subject: autoport: Add support for Haswell-Lynx Point platform ......................................................................
Patch Set 36:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/30890/comment/01b32661_c3339918?usp... : PS35, Line 7: LynxPoint
Lynx Point
Done
File util/autoport/bd82x6x.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/efc56d59_3fc74a17?usp... : PS35, Line 10: func IsPCIeHotplug(ctx Context, port int) bool {
It’d be great if you elaborated in the commit message about the refactoring.
I split out the GPIO refactoring to a separate commit, and reverted the change to `IsPCIeHotplug()` as I don't see an obvious reason it was changed.
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/feb94c8b_b575e72d?usp... : PS32, Line 24: switch g {
Sounds good. […]
Done
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/82e6139b_f6faa7cb?usp... : PS35, Line 189: "sata_port_map": fmt.Sprintf("0x%x", PCIMap[PCIAddr{Bus: 0, Dev: 0x1f, Func: 2}].ConfigDump[0x92]&0x3f),
This crashes when the SATA device is disabled.
Ack. Yeah, I'm aware of crashes when things are disabled. It also crashes if xHCI is disabled. I'll think I'll just address all these issues in a separate patch, as I think there's several instances (including in the existing snb code) that don't take into account disabled devices properly.