uwe.poeche@siemens.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36642 )
Change subject: drivers/i2c/ptn3460: Provide chip driver for PTN3460 ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36642/2/src/drivers/i2c/ptn3460/ptn... File src/drivers/i2c/ptn3460/ptn3460.h:
https://review.coreboot.org/c/coreboot/+/36642/2/src/drivers/i2c/ptn3460/ptn... PS2, Line 68: uint8_t
#include <stdint. […]
Done
https://review.coreboot.org/c/coreboot/+/36642/2/src/drivers/i2c/ptn3460/ptn... File src/drivers/i2c/ptn3460/ptn3460.c:
https://review.coreboot.org/c/coreboot/+/36642/2/src/drivers/i2c/ptn3460/ptn... PS2, Line 80: status, i, val
You could have used "val" for every call to the ptn3460_xxx-functions (so even for ptn3460_write_edi […]
Done
https://review.coreboot.org/c/coreboot/+/36642/2/src/drivers/i2c/ptn3460/ptn... PS2, Line 106: Not able
This could have been 'Unable' to sync with the case above. But I do not have a strong objection.
Done