Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32871 )
Change subject: fit_payload: Don't call prog_segment_loaded() on extracted images ......................................................................
fit_payload: Don't call prog_segment_loaded() on extracted images
Kernel handoff on all architectures supporting FIT images already includes flushing and disabling the cache. No need to waste any more time flushing individual components (especially since in the case of compressed DT overlays they will still get accessed again afterwards).
Change-Id: I7b483e920c5a71663b024b5b50804ffc84939830 Signed-off-by: Julius Werner jwerner@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/32871 Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/lib/fit_payload.c 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/lib/fit_payload.c b/src/lib/fit_payload.c index 4bc6622..c977903 100644 --- a/src/lib/fit_payload.c +++ b/src/lib/fit_payload.c @@ -88,12 +88,11 @@ }
if (!true_size) { - printk(BIOS_ERR, "ERROR: %s node failed!\n", comp_name); + printk(BIOS_ERR, "ERROR: %s decompression failed!\n", + comp_name); return true; }
- prog_segment_loaded(region->offset, true_size, 0); - return false; }