Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33283 )
Change subject: spi_flash: Add Dual SPI support ......................................................................
Patch Set 3:
From a Chrome OS standpoint, we should probably do gigadevices as well since those are dual sourced w/ winbond typically.
Yeah, it's just a matter of looking through all the datasheets to figure out which chips actually support it. And duplicating the flag in all the data structures. I'd really like if we could get most of these chip drivers in a common framework that uses the same data structure because it's all the same anyway (crbug.com/968285), but it'll probably be a while until someone has time for that. Duplicated the scheme for Gigadevice for now.