From a Chrome OS standpoint, we should probably do gigadevices as well since those are dual sourced w/ winbond typically.

Yeah, it's just a matter of looking through all the datasheets to figure out which chips actually support it. And duplicating the flag in all the data structures. I'd really like if we could get most of these chip drivers in a common framework that uses the same data structure because it's all the same anyway (crbug.com/968285), but it'll probably be a while until someone has time for that. Duplicated the scheme for Gigadevice for now.

View Change

To view, visit change 33283. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6808224c99af32b6c5c43054135c8f4c03c1feb
Gerrit-Change-Number: 33283
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 07 Jun 2019 05:24:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment