Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34642 )
Change subject: soc/intel/apl: Enable FSP usage by default
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34642/1/src/mainboard/up/squared/Kc...
File src/mainboard/up/squared/Kconfig:
https://review.coreboot.org/c/coreboot/+/34642/1/src/mainboard/up/squared/Kc...
PS1, Line 15: default y
If we enable ADD_FSP_BINARIES AND FSP_USE_REPO by default, we need this option to get the build prop […]
Done
https://review.coreboot.org/c/coreboot/+/34642/1/src/mainboard/up/squared/Kc...
PS1, Line 17: config ADD_FSP_BINARIES
: bool
: default y
:
: config FSP_USE_REPO
: bool
: default y
You are right, but see my comment before.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34642
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e1deb2d3ef676829034d0b67aa8b72a5f2fd766
Gerrit-Change-Number: 34642
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 02 Aug 2019 13:23:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment