Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36547 )
Change subject: security/vboot: Add config option to always enable the display
......................................................................
Patch Set 6: Code-Review+1
Nico, what are your thoughts on this CL vs your CL?
I can just work on top of this. The problem I see is that with
this additional Kconfig, we have, on some paths (e.g. VBOOT +
VGA OpRom), three Kconfigs controlling the very same thing.
But my approach has maintainability issues as well. Needs
some more thought.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36547
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ffaac85d2082717bb9608d536f7cec66a583789
Gerrit-Change-Number: 36547
Gerrit-PatchSet: 6
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 16 Nov 2019 11:41:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment