16 Nov
2019
16 Nov
'19
2:01 p.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36878 )
Change subject: sb/intel/common: Properly guard USB debug ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36878/2/src/southbridge/intel/commo... File src/southbridge/intel/common/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36878/2/src/southbridge/intel/commo... PS2, Line 31: bootblock-$(CONFIG_SOUTHBRIDGE_INTEL_COMMON_USB_DEBUG) += usb_debug.c
There are at least two things to consider before removing guards:
- Overrides of `weak` symbols.
- Code we don't gc, e.g. dynamically hooked-up drivers, BS hooks.
Basically, if BUILD_TIMELESS=1 is the same it's ok ;)
--
To view, visit https://review.coreboot.org/c/coreboot/+/36878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84c3401b9419f2878c2cfdf81147fa854018f9ae
Gerrit-Change-Number: 36878
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian david.guckian@intel.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 16 Nov 2019 13:01:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment