Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Angel Pons. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47006/comment/a8bdee88_21d9056d PS9, Line 68: default y I am sort of against having this enabled by default, since this adds the entire console and uart driver to SMM. You could still add it under configs/ for build-testing and production (with care).
Is this change done in co-operation with maintainer Quanta? I am not convinced you really need to adjust SMM loglevel, but if you do, do you really want it done via VPD for production or would a Kconfig for development be enough?
Also, UART should be excluded from OS with DEBUG_SMI=y due the console_init() call, e.g. interrupts will get disabled and baudrate potentially changed. OS may not survive from this.
File src/mainboard/ocp/deltalake/loglevel_vpd.c:
https://review.coreboot.org/c/coreboot/+/47006/comment/d81d2519_edd1d8ce PS9, Line 9: int get_console_loglevel(void) Okay, so with DEBUG_SMI=y console_init() is called once every time SMI is entered. The code in console/init.c does not really expect that, and it currently unconditionally calls get_console_loglevel() every time, while doing it just once would be just fine.
I guess this is what motivated for change CB:49460?