KOUAM Ledoux has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43756 )
Change subject: lib/cbmem: Change the return type of cbmem_top_chipset to uinptr_t
......................................................................
Patch Set 29:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/43756/21/src/northbridge/intel/x4x/...
File src/northbridge/intel/x4x/memmap.c:
https://review.coreboot.org/c/coreboot/+/43756/21/src/northbridge/intel/x4x/...
PS21, Line 7: include <stdint.h>
please remove the one you added and keep the old one.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43756
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12b105a5b49e2bbe2753a75eeff28fed29ee2297
Gerrit-Change-Number: 43756
Gerrit-PatchSet: 29
Gerrit-Owner: KOUAM Ledoux
kouamdoux@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: KOUAM Ledoux
kouamdoux@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 26 Jul 2020 12:29:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment