Attention is currently required from: Angel Pons. Michael Büchler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45317 )
Change subject: mb/asrock: Add ASRock H77 Pro4-M mainboard ......................................................................
Patch Set 5:
(12 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45317/comment/3400a0d6_b60d3596 PS2, Line 32: - S3 suspend/resume from either Linux or Windows 10. Now it immediately : resumes.
That means Super I/O power management is bonkers.
It came back to its senses. With the soldering inbetween I can't really say what the issue was, but it works again.
Commit Message:
https://review.coreboot.org/c/coreboot/+/45317/comment/76f7e5bb_333fa0de PS4, Line 30: (needs VGA BIOS)
I know Windows 10 works on Sandy/Ivy without a VGA BIOS when: […]
I gave this a try and it works well until Windows 10 installs the graphics drivers, then the display goes black/standby and never comes back until I use the VGA BIOS or a PCIe graphics card. So for now I think the statement still holds.
https://review.coreboot.org/c/coreboot/+/45317/comment/1d29e8fd_213a1df5 PS4, Line 42: SATA 6Gb/s
I imagine this is because none of your SATA drives are 6Gbps-capable?
I have some, but I had not checked if they actually get configured for 6Gbps and show transfer rates >3Gbps. Now I tested it for both controllers (H77 and ASM1061) and it looks OK.
https://review.coreboot.org/c/coreboot/+/45317/comment/a3bd3914_5d61a68f PS4, Line 43: Rear eSATA connector
It's multiplexed with the second SATA port of the ASM1061. […]
Confirmed. Attaching an eSATA drive disconnects the internal drive on the upper of the two ASM1061 ports (SATA3_A1) and clears the bit that corresponds to GP23 in the Super I/O registers. Good to know.. I should add this to the documentation I guess? Thanks for investigating!
File src/mainboard/asrock/h77pro4-m/Kconfig:
https://review.coreboot.org/c/coreboot/+/45317/comment/cf82b5fd_48158c14 PS4, Line 26: config INTEL_GMA_VBT_FILE : string : default "src/mainboard/$(MAINBOARDDIR)/data.vbt" : : config INTEL_GMA_ADD_VBT : bool : default y
Remove these and simply select `INTEL_GMA_HAVE_VBT`
Done
File src/mainboard/asrock/h77pro4-m/acpi_tables.c:
PS4:
This file can be removed. The GNVS values aren't used.
Done
File src/mainboard/asrock/h77pro4-m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45317/comment/951ae2ca_543982d2 PS4, Line 4: 0x0
nit: Use `0` instead of `0x0`
Done
https://review.coreboot.org/c/coreboot/+/45317/comment/78378e70_19fe931b PS4, Line 9: 0x0
nit: same
Done
https://review.coreboot.org/c/coreboot/+/45317/comment/4c4b0301_5bc5e911 PS4, Line 13: 0x0
nit: same
Done
https://review.coreboot.org/c/coreboot/+/45317/comment/107834b2_c6761a77 PS4, Line 22: register "c2_latency" = "0x0065"
Can be removed, it's the default value when unspecified.
Done
File src/mainboard/asrock/h77pro4-m/early_init.c:
https://review.coreboot.org/c/coreboot/+/45317/comment/560be341_b7ba908b PS4, Line 54: /* Configure GPIO7 */ : pnp_set_logical_device(GPIO6789_DEV); : pnp_write_config(GPIO6789_DEV, 0xe0, 0x3f); : pnp_write_config(GPIO6789_DEV, 0xe1, 0x7f);
As per the Z77 Pro4-M boardview, these two GPIOs control which of the two CPU fan headers should the […]
Nice, I was able to confirm this by setting these GPIOs from a booted Linux. Setting the GPIO to '0' connects the fan tachometer signal to the Super I/O as you said. Just your example code mixes it up a little. This should be correct: ``` pnp_write_config(GPIO6789_DEV, 0xe1, 0xff); /* CPU fan speed would always be 0 */ pnp_write_config(GPIO6789_DEV, 0xe1, 0x7f); /* CPU fan speed reports CPU_FAN1 speed */ pnp_write_config(GPIO6789_DEV, 0xe1, 0xbf); /* CPU fan speed reports CPU_FAN2 speed */ pnp_write_config(GPIO6789_DEV, 0xe1, 0x3f); /* Both connected, wrong readings if both present */ ``` An easy way to configure this would indeed be nice. Can you suggest something? A value in NVRAM (cmos.layout) seems useful..
File src/mainboard/asrock/h77pro4-m/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/45317/comment/4fb73621_5abda53d PS4, Line 6: Realtek
nit: Realtek ALC892
Done