[coreboot-gerrit] [L] Change in coreboot[main]: [RFC] Add UPL FDT handoff

[Benjamin Doron (Code Review)]

Attention is currently required from: Arthur Heymans, Jakub Czapiga, Julius Werner, Jérémy Compostella, Lean Sheng Tan, Matt DeVillier, Maximilian Brune, Philipp Hug, Simon Glass, ron minnich.

Benjamin Doron has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/76591?usp=email )

Change subject: [RFC] Add UPL FDT handoff
......................................................................

Patch Set 22:

(1 comment)

File src/drivers/uart/pl011.c:

https://review.coreboot.org/c/coreboot/+/76591/comment/9e311440_69746dc8?usp... :
PS15, Line 88: u32 addr_cells = 0, size_cells = 0;
             : 	struct device_tree_node *uart_node = dt_find_node(parent_node, serial_path, &addr_cells, &size_cells, 1);
             : 
             : 	u64 reg_addrs[] = { uart_platform_base(CONFIG_UART_FOR_CONSOLE) };
             : 	u64 reg_sizes[] = { 0x1000 };
             : 	dt_add_reg_prop(uart_node, reg_addrs, reg_sizes, 1, addr_cells, size_cells);
             : 	dt_add_string_prop(uart_node, "compatible", "arm,pl011");
             : 	dt_add_u32_prop(uart_node, "clock-frequency", uart_platform_refclk());
             : 	dt_add_u32_prop(uart_node, "current-speed", get_uart_baudrate());
             : 	dt_add_u32_prop(uart_node, "reg-io-width", sizeof(uint8_t));
> I did it all in runtime for simplicity sake, because I couldn't really come up with a build time sol […]

Can moving this to buildtime be something to consider for the future instead? Currently, this patchset is about making FDT an alternative to CBTABLEs: I don't think we need to explode its scope by turning both into buildtime + runtime jobs just yet.