Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34912 )
Change subject: rmodule: Add R_386_16 to valid reloc ......................................................................
Patch Set 3:
Why is this one actually needed? Aren't you linking your romstage statically?
Yes. However this is an example of all the little things that turn out to be different enough to cause small problems. This is due to passing --xip to cbfstool for romstage. If I try to use NO_XIP_EARLY_STAGES, I hit cbfs-mkstage.c "Conflicting sections in segment".
So in hindsight, this is the wrong tool for the job. I actually prefer to keep romstage out of the image altogether, as it's burning space. And I don't care that it's made into a stage; I only need the elf in order to create the compressed image for the PSP. Will reorient this patch shortly.