EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35241 )
Change subject: mb/google/drallion: dynamic disable memory channel
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35241/2/src/mainboard/google/dralli...
File src/mainboard/google/drallion/romstage.c:
https://review.coreboot.org/c/coreboot/+/35241/2/src/mainboard/google/dralli...
PS2, Line 65: DisableDimmChannel0
I don't understand the comment.
I means this is Drallion feature only, and I didn't know why this need based on read_type? This project will remove the other variant later. So we only have one read type.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35241
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5f53f0ba3bd432fbcb7513d2a8aa49d42f7a23e
Gerrit-Change-Number: 35241
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Sep 2019 07:55:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment