[coreboot-gerrit] Change in coreboot[master]: amd/picasso: Load x86 microcode from CBFS modules

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )

Change subject: amd/picasso: Load x86 microcode from CBFS modules
......................................................................

Patch Set 22: Code-Review+2

(3 comments)

https://review.coreboot.org/c/coreboot/+/41719/20/src/soc/amd/picasso/update... 
File src/soc/amd/picasso/update_microcode.c:

https://review.coreboot.org/c/coreboot/+/41719/20/src/soc/amd/picasso/update... 
PS20, Line 52: 		(new_patch_id == m->patch_id) ? "success" : "fail");
> microcode: Updating to patch id = 0x%08x %s\n … succeeded/failed […]

Done

https://review.coreboot.org/c/coreboot/+/41719/20/src/soc/amd/picasso/update... 
PS20, Line 69: 		m++) {
> This fits on the line above.

Done

https://review.coreboot.org/c/coreboot/+/41719/22/src/soc/amd/picasso/update... 
File src/soc/amd/picasso/update_microcode.c:

https://review.coreboot.org/c/coreboot/+/41719/22/src/soc/amd/picasso/update... 
PS22, Line 54: updated
same as i commented on the patch before this one