[coreboot-gerrit] Change in ...coreboot[master]: [WIP]arch/x86/postcar: Add x86_64 support

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30500 )

Change subject: [WIP]arch/x86/postcar: Add x86_64 support
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/30500/4/src/arch/x86/exit_car.S 
File src/arch/x86/exit_car.S:

https://review.coreboot.org/#/c/30500/4/src/arch/x86/exit_car.S@118 
PS4, Line 118: 	pop	%ebx	/* Number to clear */
> It's fine like this. […]

Something like this might do it, if we want to:

pop_edx_eax
  mov %al, %bl /* Number to clear */
  mov %dl, %bh /* Number to set */
  test %bl, %bl
  jz 2f
  ...
  dec %bl
  jnz 1b

2:
  test %bh, %bh
  jz 2f
  ...
  dec %bh
  jnz 1b