Attention is currently required from: Julius Werner, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 )
Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h ......................................................................
Patch Set 9:
(3 comments)
File util/cbfstool/cbfs.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136703): https://review.coreboot.org/c/coreboot/+/60233/comment/6db2bd00_2f567993 PS9, Line 57: #define CBFS_SUBHEADER(_p) ( (void *) ((((uint8_t *) (_p)) + be32toh((_p)->offset))) ) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136703): https://review.coreboot.org/c/coreboot/+/60233/comment/13066bad_b0b17dac PS9, Line 57: #define CBFS_SUBHEADER(_p) ( (void *) ((((uint8_t *) (_p)) + be32toh((_p)->offset))) ) space prohibited before that close parenthesis ')'
File util/cbfstool/cbfs_image.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136703): https://review.coreboot.org/c/coreboot/+/60233/comment/8d6b2540_ded957fd PS9, Line 89: if (((char *)entry) + be32toh(entry->offset) == hdr_loc) { braces {} are not necessary for single statement blocks