Julius Werner has posted comments on this change. ( https://review.coreboot.org/29253 )
Change subject: security/vboot: build vboot_fw20.a per stage ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29253/1/src/security/vboot/Makefile.inc File src/security/vboot/Makefile.inc:
https://review.coreboot.org/#/c/29253/1/src/security/vboot/Makefile.inc@87 PS1, Line 87: vboot_reference-$(1) Isn't there a way to map multiple stages to vboot_reference-$(ARCH-$(1)-y) or something like that, so that you don't end up building the same code multiple times in the vast majority of cases where the architecture will be the same? There may be some differences in $(CFLAGS_$(1)) and such (e.g. -D__VERSTAGE__ vs. -D__ROMSTAGE__), but none that should affect vboot in any way. So you could just pick one of them or throw them all together or something and it should still work.