Attention is currently required from: Kapil Porwal, Nick Vaccaro, Subrata Banik, sridhar siricilla.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80362?usp=email )
Change subject: soc/intel/cmn/sa: Add APIs into System Agent (SA) common code ......................................................................
Patch Set 8: Code-Review+2
(8 comments)
Patchset:
PS8: few nits
File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/80362/comment/1ffd48f6_90561b6a : PS8, Line 330: uint32_t const?
https://review.coreboot.org/c/coreboot/+/80362/comment/21ab4540_3d226810 : PS8, Line 339: mmcfg_length = 4ULL * GiB; : break; Nit: just 'return 4 * GiB' is more concise
https://review.coreboot.org/c/coreboot/+/80362/comment/e18b2520_b982cf54 : PS8, Line 361: pciexbar_reg & PCIEXBAR_LENGTH_MASK Shift the bits?
https://review.coreboot.org/c/coreboot/+/80362/comment/784886ef_f2dddb95 : PS8, Line 373: uint32_t const?
https://review.coreboot.org/c/coreboot/+/80362/comment/d35a00c1_362b4676 : PS8, Line 402: uint64_t size; is this variable necessary? Just return size straight away in the switch statement?
https://review.coreboot.org/c/coreboot/+/80362/comment/a1dae4d6_ee480448 : PS8, Line 403: uint32_t size_field const?
https://review.coreboot.org/c/coreboot/+/80362/comment/53542a6a_af545e49 : PS8, Line 417: default: move above case 0?