Attention is currently required from: Kapil Porwal, Nick Vaccaro, Subrata Banik, sridhar siricilla.
Patch set 8:Code-Review +2
8 comments:
Patchset:
few nits
File src/soc/intel/common/block/systemagent/systemagent.c:
Patch Set #8, Line 330: uint32_t
const?
mmcfg_length = 4ULL * GiB;
break;
Nit: just 'return 4 * GiB' is more concise
Patch Set #8, Line 361: pciexbar_reg & PCIEXBAR_LENGTH_MASK
Shift the bits?
Patch Set #8, Line 373: uint32_t
const?
Patch Set #8, Line 402: uint64_t size;
is this variable necessary? Just return size straight away in the switch statement?
Patch Set #8, Line 403: uint32_t size_field
const?
Patch Set #8, Line 417: default:
move above case 0?
To view, visit change 80362. To unsubscribe, or for help writing mail filters, visit settings.