Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Zhuohao Lee.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53908 )
Change subject: mb/google/volteer: adjust the size for RO/RW mcache
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Maybe the best course of action is just to remove the global RW_PERCENTAGE default for Chrome OS (make it always default to 50) and globally increase the MCACHE_SIZE default for x86 to 16K. I just made the current values up and clearly my assumptions were not quite realistic. For the RW asset override I'm still kinda hoping that'll remain a rare exception, but on the other hand this size is not something we can increase after RO has been frozen so it's probably safer to always anticipate it just in case. As long as we have the CAR space available, there's no reason not to use it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53908
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9552bc9fa5d36b1ca662c9da030ae7b137b60a8
Gerrit-Change-Number: 53908
Gerrit-PatchSet: 2
Gerrit-Owner: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Fri, 07 May 2021 21:03:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment