Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31086 )
Change subject: payloads/ipxe: Enable HTTPS support ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31086/4/payloads/external/iPXE/Makefile File payloads/external/iPXE/Makefile:
https://review.coreboot.org/#/c/31086/4/payloads/external/iPXE/Makefile@56 PS4, Line 56: sed 's|.*DOWNLOAD_PROTO_HTTPS|#define DOWNLOAD_PROTO_HTTPS|g' "$(project_dir)/src/config/general.h" > "$(project_dir)/src/config/general.h" This reading from / redirecting to the same file is not supposed to work. The shell first creates an empty file, then runs the sed command. `sed` + `mv` is the standard solution for this situation (see above).
You have moved this into the `ifeq` btw.