Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45115 )
Change subject: soc/amd/picasso: Assign IOAPIC IDs, GNB APIC base with FSP
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45115/4/src/soc/amd/picasso/fsp_par...
File src/soc/amd/picasso/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45115/4/src/soc/amd/picasso/fsp_par...
PS4, Line 132: CONFIG_MAX_CPUS
PICASSO_FCH_IOAPIC_ID
Actually CONFIG_PICASSO_FCH_IOAPIC_ID
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57d3d6b2ebd8b5d511dbcb4324ea065cc3111a2d
Gerrit-Change-Number: 45115
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Sep 2020 17:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment