Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29770 )
Change subject: mb/intel/icelake_rvp: Add ICL U and Y DIMM configuration ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/29770/1/src/mainboard/intel/icelake_rvp/Make... File src/mainboard/intel/icelake_rvp/Makefile.inc:
https://review.coreboot.org/#/c/29770/1/src/mainboard/intel/icelake_rvp/Make... PS1, Line 24: extra line
https://review.coreboot.org/#/c/29770/1/src/mainboard/intel/icelake_rvp/boar... File src/mainboard/intel/icelake_rvp/board_id.c:
https://review.coreboot.org/#/c/29770/1/src/mainboard/intel/icelake_rvp/boar... PS1, Line 31: /* : * Get Board ID via EC I/O port write/read : */ make single line comment