Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35108 )
Change subject: soc/skylake: do not rely on P2SB data to generate DRHD
......................................................................
Patch Set 2: -Code-Review
(1 comment)
Patch Set 1: Code-Review+1
Patch Set 1: Code-Review+1
no fireworks. booting with 'intel_iommu=on' works as expected
Tested asrock-h110 and works well
Thanks for testing :D
https://review.coreboot.org/c/coreboot/+/35108/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35108/1//COMMIT_MSG@18
PS1, Line 18: Note that the possibility of fireworks happening has not been ruled out.
Blocking because of this.
No longer a blocker, change has been tested by two people on desktop and mobile platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35108
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7eb20182380b953a1842083e7a3c67919d6971b9
Gerrit-Change-Number: 35108
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 28 Aug 2019 19:02:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment