Attention is currently required from: Subrata Banik.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44815 )
Change subject: util/ifdtool: Identify chipset without platform name
......................................................................
Patch Set 5:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44815/comment/a0486ee0_c932fbce
PS5, Line 168: guess_ifd_2_chipset
Something that would help is to know the *length* of the soft strap lists. […]
Can you please take a look into CB:54305, used the same logic to identify the chipsets.
if you can test out Lynx Point with that CL?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44815
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83763adb721e069343b19a10e503975ffa6abb24
Gerrit-Change-Number: 44815
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Fri, 14 May 2021 21:06:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment