Attention is currently required from: Arthur Heymans, Martin L Roth.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76506?usp=email )
Change subject: soc/amd/genoa: Add aoac.c & enable AOAC devices early
......................................................................
Patch Set 8:
(1 comment)
File src/soc/amd/genoa/include/soc/aoac_defs.h:
https://review.coreboot.org/c/coreboot/+/76506/comment/886daef5_b09d3f3d :
PS7, Line 17: #define FCH_AOAC_DEV_UART3 26
: #define FCH_AOAC_DEV_UART4 20
does genoa have uart3 and 4? from the devicetree i'd assume that it has only uarts 0..2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76506?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic9553e6016c92c9b1678c395cd6a9e6860bf8a76
Gerrit-Change-Number: 76506
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 29 Sep 2023 18:41:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment