Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46120 )
Change subject: mb/google/poppy/variant/atlas: Reset bluetooth on boot ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG@7 PS1, Line 7: mb/google/poppy/variant/atlas: Reset bluetooth in BIOS
Please avoid the term BIOS at least in summaries. ;-) […]
Done
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG@13 PS1, Line 13: down-rev
older firmware, as in the opposite of to "up-rev" firmware
Done
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG@14 PS1, Line 14: makes no attempt update
*to* update
Done
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG@12 PS1, Line 12: If the BT chip is : already running down-rev firmware from a previous boot, the driver : makes no attempt update the BT firmware by resetting it. This can lead : to unexpected behavior across system upgrades.
It's not Linux-specific, it's specific to the Bluetooth module.
b:168757348 captures this behavior.
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG@16 PS1, Line 16: BIOS
coreboot 😋
Done
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG@17 PS1, Line 17:
Please describe the change. […]
line 9 says it all. force reset.
https://review.coreboot.org/c/coreboot/+/46120/1//COMMIT_MSG@20 PS1, Line 20:
For sure :) I just mean to tag this with BRANCH=poppy or something
it would be BRANCH=atlas, but i think this is meaningless. this change is relevant on ToT and we will need to cherry-pick it to the atlas firmware branch and up-rev the firmware updater in the next shipping chrome os image to close the bug.