[coreboot-gerrit] Change in coreboot[master]: soc/amd: Move SCI enable outside table creation

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36811 )

Change subject: soc/amd: Move SCI enable outside table creation
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36811/3/src/soc/amd/stoneyridge/acp... 
File src/soc/amd/stoneyridge/acpi.c:

https://review.coreboot.org/c/coreboot/+/36811/3/src/soc/amd/stoneyridge/acp... 
PS3, Line 81: 	memset((void *)fadt, 0, sizeof(acpi_fadt_t));
> What's the motivation for zero-initializing each field explicitly?

I would say only code clarity, as the whole area is 0 initialized.
However, if you think that some should be removed (as you did initially) than all should be removed. And that would lose code clarity, though I will accept if you do so.