build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34781 )
Change subject: dram: Add CRC16 checks for DDR4
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34781/1/src/device/dram/ddr4.c
File src/device/dram/ddr4.c:
https://review.coreboot.org/c/coreboot/+/34781/1/src/device/dram/ddr4.c@48
PS1, Line 48: {.type = BLOCK_3, 384, 128, 0}};
space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34781/1/src/device/dram/ddr_common....
File src/device/dram/ddr_common.c:
https://review.coreboot.org/c/coreboot/+/34781/1/src/device/dram/ddr_common....
PS1, Line 36: if (crc & 0x8000) {
braces {} are not necessary for any arm of this statement
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34781
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief5a5f0575f3b8e34bb050b1e09a4b2462a93450
Gerrit-Change-Number: 34781
Gerrit-PatchSet: 1
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 07 Aug 2019 20:16:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment