Attention is currently required from: Andrey Petrov, Arthur Heymans, Julius Werner, Karthik Ramasubramanian, Nick Vaccaro, Yu-Ping Wu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77796?usp=email )
Change subject: {commonlib, libpayload}: Add "is_external display" in coreboot table
......................................................................
Patch Set 4:
(3 comments)
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/77796/comment/210c3530_4c05bb76 :
PS2, Line 241: u8 is_external_display;
Let's make this a `flags` field and define is_external_display as bit 0.
Acknowledged
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/77796/comment/1919faed_65b01774 :
PS2, Line 452: on-display
Nit: on-board
Acknowledged
File src/drivers/intel/fsp2_0/graphics.c:
https://review.coreboot.org/c/coreboot/+/77796/comment/496d6474_b43a2ff3 :
PS2, Line 126: framebuffer_bar
+1
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77796?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0fa7eee4c5a50371a7a66c6ca1ac2c7d046d010b
Gerrit-Change-Number: 77796
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 02 Oct 2023 21:27:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment