27 Nov
2019
27 Nov
'19
2:54 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37285 )
Change subject: mb/lenovo/t420s/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37285/1/src/mainboard/lenovo/t420s/... File src/mainboard/lenovo/t420s/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37285/1/src/mainboard/lenovo/t420s/... PS1, Line 2: # IGD Displays
This change is out of the scope of this commit
Um, let me rephrase: this is not mentioned in the commit message, so it struck as odd. I see the comment comes from the t420 devicetree, but why?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37285
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia77f0ce89b2234b9c164bb326d76bef98949832a
Gerrit-Change-Number: 37285
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Nov 2019 14:54:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment