build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28661 )
Change subject: soc/intel/cannonlake: Move the FSP related callbacks to separate files ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/28661/5/src/soc/intel/cannonlake/fsp_params.... File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/28661/5/src/soc/intel/cannonlake/fsp_params.... PS5, Line 82: for (i = 0; i < ARRAY_SIZE(params->Usb2OverCurrentPin); i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/28661/5/src/soc/intel/cannonlake/fsp_params.... PS5, Line 86: for (i = 0; i < ARRAY_SIZE(params->Usb3OverCurrentPin); i++) { braces {} are not necessary for single statement blocks