Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47726 )
Change subject: soc/amd/picasso: Add data fabric read helper function
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47726/2/src/soc/amd/picasso/include...
File src/soc/amd/picasso/include/soc/data_fabric.h:
https://review.coreboot.org/c/coreboot/+/47726/2/src/soc/amd/picasso/include...
PS2, Line 62: BIT(0)
Done
Hmm, we seem to oscillate back and forth. There was a big push before to use BIT().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47726
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0dc72063fbb99efaeea3fccef16cc1b5b8526f1
Gerrit-Change-Number: 47726
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Dec 2020 16:12:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment