[coreboot-gerrit] Change in coreboot[master]: [WIP] soc/intel/broadwell: Skip PRE_GRAPHICS_DELAY

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Matt DeVillier, Duncan Laurie, Angel Pons.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48787 )

Change subject: [WIP] soc/intel/broadwell: Skip PRE_GRAPHICS_DELAY
......................................................................

Patch Set 6:

(1 comment)

File src/soc/intel/broadwell/gma.c:

https://review.coreboot.org/c/coreboot/+/48787/comment/67d52290_0e903c78 
PS2, Line 516: if (!acpi_is_wakeup_s3()) {
             : 		if (!CONFIG(CHROMEOS) || display_init_required())
> I'm perfectly ok with dropping the entire hunk here. […]

The comments in Kconfig suggest that it was mainly problems with external monitors or TVs why the delay was added (and why it is a visible option). Probably case of DDC/EDID power sequencing when monitor is in one of the deeper suspend/standby modes.

If there is a problem with OPROM not retrying long enough, the default delay should probably be the experimental 50ms for platforms without panels.