[coreboot-gerrit] Change in ...coreboot[master]: soc/fsp_broadwell_de: fix flashconsole support for platform

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32880 )

Change subject: soc/fsp_broadwell_de: fix flashconsole support for platform
......................................................................

Patch Set 1:

I would vote for keeping the common SPI code and adding the CAR_GLOBAL usage back to it.
It has been removed without any file checked and as Kyösti mentioned earlier it was kind of expected that there will be some trouble. For fsp_broadwell_de we need this in the SPI code to be able to use it in stages prior to ramstage and there are valid cases for that.
And using CAR_GLOBAL in common code is fine for me. Once we make the step to remove FSP1.0 from master (and therefore remove fsp_broadwell_de and fsp_baytrail) we can get rid of it. But this will take at least 1/2 to 1 year from now and in the meantime it would be good to have a working solution for it.