Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32243 )
Change subject: mediatek/mt8183: support SAMSUNG and MICRON EMCP LPDDR4X DDR bootup ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/#/c/32243/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32243/4//COMMIT_MSG@13 PS4, Line 13: than other than with other
https://review.coreboot.org/#/c/32243/4//COMMIT_MSG@13 PS4, Line 13: begin start of
https://review.coreboot.org/#/c/32243/4//COMMIT_MSG@13 PS4, Line 13: early earlier
https://review.coreboot.org/#/c/32243/4//COMMIT_MSG@12 PS4, Line 12: from the calibration log of MICRON MT29VZZZAD8DQKSL, we found : the begin pass range of RX window early than other DDR type. Why is that a bad thing? Is that contradicting some specification?
https://review.coreboot.org/#/c/32243/4//COMMIT_MSG@14 PS4, Line 14: change Change