13 Nov
2020
13 Nov
'20
11:25 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47556 )
Change subject: ambassador: update fan table and usb configs ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47556/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/ambassador/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47556/1/src/mainboard/google/hatch/... PS1, Line 3: egister "HeciEnabled" = "1" intentionally dropped? Probably because you are enabling 16.0? It would be good to add that to commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47556
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f727f0f7e2eb7fe70385ebc843558d51e1860c5
Gerrit-Change-Number: 47556
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Ziegelbaum ziegs@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 13 Nov 2020 23:25:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment