David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39715 )
Change subject: configs: Add builder Tioga Pass config
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
minor nit
https://review.coreboot.org/c/coreboot/+/39715/4/configs/builder/config.ocp....
File configs/builder/config.ocp.tiogapass:
https://review.coreboot.org/c/coreboot/+/39715/4/configs/builder/config.ocp....
PS4, Line 16: CONFIG_IFD_BIN_PATH="site-local/tiogapass/descriptor.bin"
IFD path should be left as default since it's committed to the blobs repo (3rdparty/blobs/mainboard/$(MAINBOARDDIR)/descriptor.bin)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39715
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifff3591ef9fff40117c60e85900bde9c3729bd94
Gerrit-Change-Number: 39715
Gerrit-PatchSet: 4
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 25 Mar 2020 01:57:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment