Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35035 )
Change subject: arch/x86: Implement RESET_VECTOR_IN_RAM
......................................................................
Patch Set 28:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35035/28/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35035/28/Makefile.inc@1055
PS28, Line 1055: $(CBFSTOOL) $@.tmp add-master-header $(TS_OPTIONS)
CB:34477 has a clue the very end of coreboot.rom will be modified by cbfstool. […]
Kyösti, thanks for the reminder on that. I'm not a fan of the 'add-master-header' as it is because of the manipulation of content not really a part of the program that resides there. I do agree we need to sort out the .id section as well. I think this add-master-header should also be optional. I'm not sure you should revert CB:34477 just yet.
That said, picasso's boot architecture doesn't necessitate bootblock (or whatever the first thing x86 runs) being in cbfs proper. However, that's going to take some amdfwtool changes to make such a setup work because it's my understanding that utility just puts *everything* into one block.
I'm going to remove these guards about adding bootblock.bin and push a new patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c084ff6fdcf7e9154436f038705e8679daea780
Gerrit-Change-Number: 35035
Gerrit-PatchSet: 28
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Apr 2020 05:12:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment