Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45367 )
Change subject: nb/intel/ironlake: Avoid casting pointers to structs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45367/2/src/northbridge/intel/ironl...
File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/45367/2/src/northbridge/intel/ironl...
PS2, Line 1750: message->dwords + (current_position >> 2),
just a thought, the compiler might be able to "see" it more clearly if array indexing is used (message->dwords[current_position>>2]).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45367
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60e3dca7ad101d840759bdc0c88c50d9f07d65e2
Gerrit-Change-Number: 45367
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Sat, 19 Sep 2020 01:49:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment