Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36941 )
Change subject: arch/x86: SMBIOS: Improve core count reporting ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36941/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/36941/2/src/arch/x86/smbios.c@677 PS2, Line 677: t->core_count = (res.ebx >> 16) & 0xff;
I was talking about the runtime extended devicetree where after MP init you will have the real numbe […]
oh I see. Yeah that would be good idea and perhaps should be implemented long term. We would to refactor this file a bit though
https://review.coreboot.org/c/coreboot/+/36941/3/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/36941/3/src/arch/x86/smbios.c@673 PS3, Line 673: if (leaf_b_threads == 0) {
braces {} are not necessary for single statement blocks
this is fine, ignore this