Attention is currently required from: Arthur Heymans. Hello Arthur Heymans,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/59660
to review the following change.
Change subject: oprom/realmode/x86.c: Fix building for ENV_X86_64 ......................................................................
oprom/realmode/x86.c: Fix building for ENV_X86_64
Not tested on hardware.
Change-Id: I8ce8d56da326aeff5ff9b400ded02d4309372519 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/device/oprom/realmode/x86.c 1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/59660/1
diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c index 224e49b..38452f5 100644 --- a/src/device/oprom/realmode/x86.c +++ b/src/device/oprom/realmode/x86.c @@ -89,13 +89,21 @@ .edi=X86_EDI, .vector=M.x86.intno, .error_code=0, // FIXME: fill in +#if ENV_X86_64 + .rip=X86_EIP, +#else .eip=X86_EIP, +#endif .cs=X86_CS, +#if ENV_X86_64 + .rflags=X86_EFLAGS +#else .eflags=X86_EFLAGS +#endif }; struct eregs *regs = ®_info;
- printk(BIOS_INFO, "Oops, exception %d while executing option rom\n", + printk(BIOS_INFO, "Oops, exception %lld while executing option rom\n", regs->vector); x86_exception(regs); // Call coreboot exception handler