Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34995 )
Change subject: arch/x86: Add postcar_frame_setup_top_of_dram_usage() API ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34995/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34995/3//COMMIT_MSG@7 PS3, Line 7: arch/x86: Add postcar_frame_setup_top_of_dram_usage() API intel/cannonlake: Cache the TSEG region
Patchset #2 commit message was just fine.
https://review.coreboot.org/c/coreboot/+/34995/3/src/arch/x86/postcar_loader... File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/34995/3/src/arch/x86/postcar_loader... PS3, Line 153: MTRR_TYPE_WRBACK);
I understood but isn't it also true that we want to also pass this savings into some common code lik […]
Remember what I wrote earlier about postcar_frame_setup_top_of_dram_usage() setting new requirements for the alignments, should you call set_var_mtrr() from inside of it? That's why it is currently being rejected. Or at least it will not receive +2 from me, and I anticipate that Aaron and Furguain may share my opinion.