Attention is currently required from: Tarun Tuli, Subrata Banik, Angel Pons, Arthur Heymans, Lean Sheng Tan, Eric Lai.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69975 )
Change subject: soc/intel/cmn/cse: Send EOP cmd from .final aka `cse_final()`
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/69975/comment/28180456_63c3473c
PS2, Line 1265: if (CONFIG(SOC_INTEL_CSE_SET_EOP))
It is changing behavior for tigerlake where `USE_FSP_NOTIFY_PHASE_READY_TO_BOOT` and `SOC_INTEL_CSE_ […]
Even alderlake has both `SOC_INTEL_CSE_SEND_EOP_EARLY` and `SOC_INTEL_CSE_SET_EOP` selected. This change will make alderlake send the EOP twice.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69975
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I412291c9378011509d3825f9b01e81bfced53303
Gerrit-Change-Number: 69975
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 28 Nov 2022 06:47:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment